feature(hash): refactor sha256 hash api #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
force-pushed
the
Rexicon226/hash-refactor
branch
from
8838aba to
5985c27
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Rexicon226
force-pushed
the
Rexicon226/hash-refactor
branch
from
5985c27 to
20694bb
Compare
yewman
reviewed
Sep 29, 2025
Contributor
yewman
left a comment
yewman
left a comment
There was a problem hiding this comment.
Looks good to me, just one small comment on a missed signature_count being hashed in conformance and small style preference
Rexicon226
force-pushed
the
Rexicon226/hash-refactor
branch
from
20694bb to
be5589e
Compare
dnut
previously requested changes
Oct 1, 2025
Rexicon226
force-pushed
the
Rexicon226/hash-refactor
branch
from
be5589e to
405e63b
Compare
InKryption
approved these changes
Oct 15, 2025
dnut
approved these changes
Oct 20, 2025
Sobeston
pushed a commit
that referenced
this pull request
Oct 29, 2025
This is a WIP PR where I focus on improving performance around sha256 related things. The first commit re-organizes the API a bit to make it easier to streamline the hashing later on. Single hashes do not need to go through a incremental API and instead can be pipelined when done in a loop, something to-be-implemented. And when doing mixins with just two inputs of a known size, we can pipeline that as well, performing much faster hashing than what we currently achieve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR where I focus on improving performance around sha256 related things. The first commit re-organizes the API a bit to make it easier to streamline the hashing later on. Single hashes do not need to go through a incremental API and instead can be pipelined when done in a loop, something to-be-implemented. And when doing mixins with just two inputs of a known size, we can pipeline that as well, performing much faster hashing than what we currently achieve.